Fix #51 - Change token type for Django 2.1 #56
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR is similar to #52 , but takes a slightly different approach. Instead of retrofitting the new Django feature to avoid changing current code in this repo, this PR opts to add code so that previous versions of Django now operate in the new fashion.
Advantages:
Disadvantages:
enum34as a conditional dependency for Python<3.4This PR also takes the liberty of:
isort_to denote an unused variableVerbatimNodecheck for Django<1.5 (as only Django>=1.8 is supported)NB: tests run in new Tox environments will fail until #54 is merged.
I realize some of these decisions are a bit controversial, and won't mind at all if you opt to close this. I figured I'd give you an option, though!
Thanks again for your time and for the package.